prefer implicitly-defined dtors instead of user dtors with empty bodies. (#685)

Not only is this simpler, it avoids clang-tidy complaining about
warning: class * defines a non-default destructor but does not define a copy
constructor, a copy assignment operator, a move constructor or a move
assignment operator [cppcoreguidelines-special-member-functions]

diff --git a/gui/filterdlg.h b/gui/filterdlg.h
index ec7069dd7af96a62f879f447e32cfbfee7ab6d48..3ec2e71d3a6214043780374e5b65fd7479030e02 100644 (file)
--- a/gui/filterdlg.h
+++ b/gui/filterdlg.h
@@ -33,7 +33,6 @@ class FilterDialog: public QDialog
   Q_OBJECT
 public:
   FilterDialog(QWidget* parent, AllFiltersData& fd_);
-  ~FilterDialog() {}
 
   void runDialog();
 

diff --git a/gui/optionsdlg.cc b/gui/optionsdlg.cc
index 07e7d30f030391d07258e04f1aa7b57af3bf4dbd..59fabc5163da997c26d72a757e9125048aea962e 100644 (file)
--- a/gui/optionsdlg.cc
+++ b/gui/optionsdlg.cc
@@ -60,10 +60,6 @@ QVariant getOptionValue(QList<FormatOption> opts, int k)
 
 }
 
-//------------------------------------------------------------------------
-FileDlgManager::~FileDlgManager()
-  = default;
-
 //------------------------------------------------------------------------
 void FileDlgManager::buttonClicked()
 {

diff --git a/gui/optionsdlg.h b/gui/optionsdlg.h
index d16638f344eba074fd7d42b9a6810cf66895fd64..c10d9ac9613d2516c8b57975774c4a42f3ca76f7 100644 (file)
--- a/gui/optionsdlg.h
+++ b/gui/optionsdlg.h
@@ -40,8 +40,6 @@ public:
                  QLineEdit* le,
                  QToolButton* tb, bool isInFile);
 
-  ~FileDlgManager();
-
 private:
   QLineEdit* le;
   QToolButton* tb;

diff --git a/gui/processwait.cc b/gui/processwait.cc
index 0de38d9117d5e828a764b213ce9920c4472e6741..227591d435f52da6b6a7c736551f894019946e51 100644 (file)
--- a/gui/processwait.cc
+++ b/gui/processwait.cc
@@ -118,9 +118,6 @@ ProcessWaitDialog::ProcessWaitDialog(QWidget* parent, QProcess* process):
 
 }
 
-//------------------------------------------------------------------------
-ProcessWaitDialog::~ProcessWaitDialog()
-= default;
 //------------------------------------------------------------------------
 bool ProcessWaitDialog::getExitedNormally()
 {

diff --git a/gui/processwait.h b/gui/processwait.h
index 1cce33727852d71671b818d4b0a2288cec94932d..37c8559c3ed8330e96231b39050ce9087041dd77 100644 (file)
--- a/gui/processwait.h
+++ b/gui/processwait.h
@@ -44,7 +44,6 @@ class ProcessWaitDialog: public QDialog
 public:
   //
   ProcessWaitDialog(QWidget* parent, QProcess* process_);
-  ~ProcessWaitDialog();
 
   bool getExitedNormally();
   int getExitCode();